Skip to content

feat: Publish icons 2026/05/21#712

Open
adrienzheng-cb wants to merge 4 commits into
masterfrom
icons/2026-05-21
Open

feat: Publish icons 2026/05/21#712
adrienzheng-cb wants to merge 4 commits into
masterfrom
icons/2026-05-21

Conversation

@adrienzheng-cb
Copy link
Copy Markdown
Contributor

@adrienzheng-cb adrienzheng-cb commented May 21, 2026

What changed? Why?

Sync icons from Figma.

New icon sets (4)

  • parlaysEmpty
  • parlaysAdd
  • addModuleUI
  • openBook

Deleted / Renamed / Updated

None.

Code Connect entries regenerated (566 entries for web and mobile).

Root cause (required for bugfixes)

N/A

UI changes

See Percy visual regression results from the "Visreg Web" GitHub Actions job.

iOS Old iOS New
old screenshot new screenshot
Android Old Android New
old screenshot new screenshot
Web Old Web New
old screenshot new screenshot

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented May 21, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS ✅ See below

CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 1/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

adrienzheng-cb and others added 3 commits May 21, 2026 17:58
…g IconName

The sync-icon-code-connect script previously generated entries for every Figma
ui/* and nav/* component set without validating against the IconName type.
This produced 12 typecheck errors for entries like `tiktokLogo`, `baseLogo`,
`priceAlerts ` (trailing space), and `newsfeed` (wrong case).

The script now reads packages/icons/src/IconName.ts and skips component sets
whose generated name doesn't appear there. Also trims whitespace from raw
Figma names before camelCasing.

10 entries dropped (566 → 556).

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants